-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMN 1.5 - 'e' number equivalence #659
Conversation
@dmn-tck/contributors please review. |
Reviewed and test pass on the Trisotech Engine |
The tests for numbers with exponent are correct. However, there is a flickering test:
The offset of @Europe/Paris varies during the year (e.g. winter time vs summer time) hence the issue. The issue with appending zone ids to time literals was discussed both here and in the RTF meeting. Here we agreed to ban the usage of zone ids for time literals. In DMN 1.6 this use case was deprecated as adding the zone id does not make sense as the date is not known. I propose removing the test either here or in another PR. |
Also, we need to discuss the equality tests for ranges according to the DMN 1.5 spec. For example,
A missing/undefined endpoint is not the same as being null. When the endpoint is missing it is ignored when building the equivalent logical expression. When the endpoint is null, the result is null (error as null is compared to a comparable value) We cannot have A = B when A and B produce different results in the same expression. It is against the substitution principle. |
From discussion on the meeting - let's remove the test with time with a timezone. |
…eing removed. As per PR comments.
test removed |
…and normal ranges to be in line with 1.5. Added a few additional tests for unary comparison range equality.
As this PR is already for the equality suite, I've amended the equality checks here for unary comparison ranges as per discussions here: #663 |
@dmn-tck/contributors please re-review after the updates. |
Looks good to me. |
Not very exciting, but, some tests for numbers with exponents.
Without trying to replicate a while load of number tests I thought perhaps it easier just to test that the 'e' number and its not 'e' version are actually equal. Then, the rest is assumed .... we've proven it is a number ...